Skip to content

fix(iaas): security group rules has state drift when setting the whole port range#1435

Merged
marceljk merged 1 commit intomainfrom
fix/STACKITTPR-284-security-group-rules-port-range-has-state-drift
May 5, 2026
Merged

fix(iaas): security group rules has state drift when setting the whole port range#1435
marceljk merged 1 commit intomainfrom
fix/STACKITTPR-284-security-group-rules-port-range-has-state-drift

Conversation

@marceljk
Copy link
Copy Markdown
Contributor

@marceljk marceljk commented Apr 30, 2026

Description

relates to STACKITTPR-284, #788 and #1035

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner April 30, 2026 08:58
@marceljk marceljk force-pushed the fix/STACKITTPR-284-security-group-rules-port-range-has-state-drift branch from 95c34be to 703660c Compare April 30, 2026 09:23
@marceljk marceljk force-pushed the fix/STACKITTPR-284-security-group-rules-port-range-has-state-drift branch from 703660c to 2d8f31c Compare May 5, 2026 13:23
@marceljk marceljk enabled auto-merge (squash) May 5, 2026 13:23
@marceljk marceljk merged commit 7fb8cdb into main May 5, 2026
3 checks passed
@marceljk marceljk deleted the fix/STACKITTPR-284-security-group-rules-port-range-has-state-drift branch May 5, 2026 13:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygrouprule 25.88% (+0.44%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygrouprule/resource.go 33.08% (+0.51%) 266 (+2) 88 (+2) 178 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/securitygrouprule/resource_test.go

This was referenced May 5, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fyusel Fyusel Fyusel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marceljk @Fyusel